Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[metkit][fdb][eckit] Remove packages and tests #846

Merged
merged 1 commit into from
Oct 26, 2023
Merged

[metkit][fdb][eckit] Remove packages and tests #846

merged 1 commit into from
Oct 26, 2023

Conversation

victoria-cherkas
Copy link
Contributor

@victoria-cherkas victoria-cherkas commented Oct 26, 2023 •
edited by dominichofer
Loading

eckit

spack_c2sm only adds v1.20.2 which is already in main spack. Additionally there is no branch called '1.20.0' in eckit

fdb

spack_c2sm adds branches ("develop","inspect","fastinspect") which are not required anymore. (I added them and I don't know if anyone else uses them but I doubt it. Also better to maintain the main spack fdb package I believe.)

metkit

spack_c2sm only adds v1.9.2 which is already in main spack.

@victoria-cherkas victoria-cherkas marked this pull request as ready for review October 26, 2023 07:46
@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2023 •
edited
Loading

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-10-26 09:49 UTC

@victoria-cherkas
Copy link
Contributor Author

@dominichofer Hey Dominic what are your thoughts on removing these all together from spack_c2sm and maintaining instead only in spack/spack ? I'm trying to keep those updated: https://github.com/spack/spack/pulls?q=+is%3Apr+author%3Avictoria-cherkas+

@victoria-cherkas victoria-cherkas changed the title Remote metkit fdb and eckit packages and tests Remove metkit fdb and eckit packages and tests Oct 26, 2023
@dominichofer dominichofer changed the title Remove metkit fdb and eckit packages and tests [metkit][fdb][eckit] Remove packages and tests Oct 26, 2023
dominichofer
dominichofer approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@dominichofer dominichofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I double-checked that the back-port is redundant now 🎉

@dominichofer dominichofer merged commit 033090f into main Oct 26, 2023
3 checks passed
@dominichofer dominichofer deleted the ecmwf-packages branch October 26, 2023 09:49
@victoria-cherkas
Copy link
Contributor Author

victoria-cherkas commented Oct 26, 2023 •
edited
Loading

Sorry @dominichofer I just noticed fdb v5.11.17 was not in v0.20.1 of spack, since it just got merged into develop. Shall I add an extension to spack_c2sm ie the below? Before the fdb package in spack_c2sm was just copied rather than an extension anyway.

class Fdb(SpackFdb):
    """FDB (Fields DataBase) is a domain-specific object store developed at
    ECMWF for storing, indexing and retrieving GRIB data."""

    homepage = "https://github.com/ecmwf/fdb"
    url = "https://github.com/ecmwf/fdb/archive/refs/tags/5.7.8.tar.gz"

    version("5.11.17",
            sha256=
            "375c6893c7c60f6fdd666d2abaccb2558667bd450100817c0e1072708ad5591e")

@victoria-cherkas
Copy link
Contributor Author

Does spack have a regular release schedule do you know?

@victoria-cherkas victoria-cherkas mentioned this pull request Oct 26, 2023
Merged
@dominichofer
Copy link
Contributor

@victoria-cherkas I think this should be sufficient:

class Fdb(SpackFdb):
    """FDB (Fields DataBase) is a domain-specific object store developed at
    ECMWF for storing, indexing and retrieving GRIB data."""

    version("5.11.17", sha256="375c6893c7c60f6fdd666d2abaccb2558667bd450100817c0e1072708ad5591e")

@dominichofer
Copy link
Contributor

Does spack have a regular release schedule do you know?

I don't know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominichofer dominichofer dominichofer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@victoria-cherkas @dominichofer